Review: Paul Blokus -- Core treeview

Chris Young chris.young at unsatisfactorysoftware.co.uk
Tue Jun 23 19:13:17 BST 2009


On Tue, 23 Jun 2009 16:14:56 +0100, John-Mark Bell wrote:

> Precis:
> 
> This is Paul Blokus' modification of the treeview code to utilise the 
> plotter interface and thus be platform agnostic.

I checked out the branch, and the Amiga version will not compile,
probably because the Amiga platform code hasn't been updated for the
new treeviews.  I suspect this will at least also affect the RISC OS
version.

I've attached a small patch to get it to the linking stage and a copy
of the linking errors.  I'd like to see some documentation on how to
migrate my treeviews to use the new ones and how to call the new
hotlist, cookie and global history browsers (I'm assuming all this has
been moved across to the core?)

Chris

build-amiga-amiga/desktop_history_global_core.o: In function `global_history_get_recent':
history_global_core.c:(.text+0x0): multiple definition of `global_history_get_recent'
build-amiga-amiga/amiga_history.o:history.c:(.text+0x0): first defined here
build-amiga-amiga/desktop_history_global_core.o: In function `global_history_add_recent':
history_global_core.c:(.text+0x18): multiple definition of `global_history_add_recent'
build-amiga-amiga/amiga_history.o:history.c:(.text+0x24c): first defined here
build-amiga-amiga/desktop_history_global_core.o: In function `global_history_add':
history_global_core.c:(.text+0x4dc): multiple definition of `global_history_add'
build-amiga-amiga/amiga_history.o:history.c:(.text+0x7c4): first defined here
build-amiga-amiga/desktop_tree.o: In function `tree_update_URL_node':
tree.c:(.text+0x1404): multiple definition of `tree_update_URL_node'
build-amiga-amiga/amiga_tree.o:tree.c:(.text+0x16fc): first defined here
build-amiga-amiga/amiga_tree.o: In function `ami_tree_event':
tree.c:(.text+0xd94): undefined reference to `tree_handle_node_element_changed'
build-amiga-amiga/desktop_tree.o: In function `tree_update_URL_node':
tree.c:(.text+0x1478): undefined reference to `tree_icon_name_from_filetype'
tree.c:(.text+0x1488): undefined reference to `tree_get_bitmap'
build-amiga-amiga/desktop_tree.o: In function `tree_create_cookie_node':
tree.c:(.text+0x1d10): undefined reference to `tree_get_bitmap'
build-amiga-amiga/desktop_tree.o: In function `tree_create_folder_node':
tree.c:(.text+0x1f94): undefined reference to `tree_get_bitmap'
build-amiga-amiga/desktop_tree.o: In function `tree_mouse_action':
tree.c:(.text+0x35e4): undefined reference to `tree_scroll_visible'
tree.c:(.text+0x35f0): undefined reference to `tree_scroll_visible'
gmake: *** [NetSurf] Error 1

-------------- next part --------------
Index: amiga/options.h
===================================================================
--- amiga/options.h	(revision 7938)
+++ amiga/options.h	(working copy)
@@ -35,7 +35,6 @@
 extern bool option_use_os_pointers;
 extern bool option_new_tab_active;
 extern bool option_kiosk_mode;
-extern char *option_recent_file;
 extern char *option_arexx_dir;
 extern char *option_download_dir;
 extern bool option_faster_scroll;
@@ -56,7 +55,6 @@
 bool option_use_os_pointers = true; \
 bool option_new_tab_active = false; \
 bool option_kiosk_mode = false; \
-char *option_recent_file = 0; \
 char *option_arexx_dir = 0; \
 char *option_download_dir = 0; \
 bool option_faster_scroll = false; \
@@ -77,7 +75,6 @@
 { "os_mouse_pointers",	OPTION_BOOL,	&option_use_os_pointers}, \
 { "new_tab_is_active",	OPTION_BOOL,	&option_new_tab_active}, \
 { "kiosk_mode",	OPTION_BOOL,	&option_kiosk_mode}, \
-{ "recent_file",		OPTION_STRING,	&option_recent_file }, \
 { "arexx_dir",		OPTION_STRING,	&option_arexx_dir }, \
 { "download_dir",		OPTION_STRING,	&option_download_dir }, \
 { "faster_scroll",	OPTION_BOOL,	&option_faster_scroll},
Index: amiga/tree.c
===================================================================
--- amiga/tree.c	(revision 7938)
+++ amiga/tree.c	(working copy)
@@ -445,7 +445,7 @@
 		if(!node->parent) flags |= LBFLG_HIDDEN;
 
 		switch (element->type) {
-			case NODE_ELEMENT_TEXT_PLUS_SPRITE:
+/*			case NODE_ELEMENT_TEXT_PLUS_SPRITE:*/
 			case NODE_ELEMENT_TEXT:
     	    		if (lbnode = AllocListBrowserNode(3,
 					LBNA_UserData,node,


More information about the netsurf-dev mailing list