Bitmap plotter API cleanup

John-Mark Bell jmb at netsurf-browser.org
Tue Jun 30 12:19:16 BST 2009


On Tue, 2009-06-30 at 12:06 +0100, Vincent Sanders wrote:
> On Tue, Jun 30, 2009 at 11:50:24AM +0100, John-Mark Bell wrote:
> > On Tue, 2009-06-30 at 11:23 +0100, Vincent Sanders wrote:

> > > There is a single "regression" from this alteration which is that the
> > > pdf save exporter will not currently directly embed the original jpegs
> > > into pdf...has anyone actually tested this with a modern haru? I have,
> > > its broken anyway! I do intend to fix this but as a seperate piece of
> > > work to make our haru handling less explody.
> > 
> > Wise. I've no strong opinion on this regression.
> 
> Looking at it a bit more the haru lib apply *zero* sanity checking to
> teh jpegs/png etc. supplied and as we retrieve them raw from the
> internet...

Joy. I hadn't realised that haru was that lax.

> I am beginning to think our "safely" decoded bitmaps should just be
> used all the time.

Might be sensible. Of course, you pay the price with bloated PDF
files :)

> > s/bitmap_tile/bitmap/ (and rename the function, too!)
> > This applies to a number of other plotter implementations, too.
> 
> I know...I was thinking I should change as little as possible and let
> the other frontend people alter them if they want...I am happy to
> rename if thats more asthetically pleasing?

I think it is, yes.


J.




More information about the netsurf-dev mailing list